Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid using raw step data when injecting phases #3248

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Avoid using raw step data when injecting phases #3248

merged 1 commit into from
Oct 23, 2024

Conversation

happz
Copy link
Collaborator

@happz happz commented Sep 30, 2024

Actual step data containers come with type annotations and better checking.

Pull Request Checklist

  • implement the feature

@happz happz added the code | style Code style changes not affecting functionality label Sep 30, 2024
@happz happz added this to the 1.38 milestone Sep 30, 2024
@happz happz added the code | no functional change "No Functional Change" intended. Patch should not change tmt's behavior in any way. label Sep 30, 2024
@psss psss force-pushed the iquwarah-tmt-try-package branch 2 times, most recently from 1b7d1f5 to e540617 Compare October 1, 2024 07:29
Base automatically changed from iquwarah-tmt-try-package to main October 1, 2024 14:02
@happz happz force-pushed the use-plugin-data-instead-of-raw branch from d4fae72 to 547df05 Compare October 17, 2024 06:47
@happz happz added the ci | full test Pull request is ready for the full test execution label Oct 17, 2024
@happz happz marked this pull request as ready for review October 17, 2024 06:55
@happz
Copy link
Collaborator Author

happz commented Oct 17, 2024

/packit test

@happz happz force-pushed the use-plugin-data-instead-of-raw branch 2 times, most recently from dbce17e to a7cbcdb Compare October 22, 2024 07:15
psss
psss approved these changes Oct 23, 2024
View reviewed changes
Copy link
Collaborator

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for simplifying this!

@happz @psss
Avoid using raw step data when injecting phases
4a1e332 
Actual step data containers come with type annotations and better
checking.
@psss psss force-pushed the use-plugin-data-instead-of-raw branch from a7cbcdb to 4a1e332 Compare October 23, 2024 07:38
@psss psss added the status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. label Oct 23, 2024
@psss psss merged commit b058850 into main Oct 23, 2024
22 checks passed
@psss psss deleted the use-plugin-data-instead-of-raw branch October 23, 2024 09:10
@psss psss self-assigned this Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@therazix therazix therazix approved these changes

@psss psss psss approved these changes

@lukaszachy lukaszachy Awaiting requested review from lukaszachy lukaszachy is a code owner

@thrix thrix Awaiting requested review from thrix thrix is a code owner

@janhavlin janhavlin Awaiting requested review from janhavlin janhavlin is a code owner

Assignees

@psss psss

Labels
ci | full test Pull request is ready for the full test execution code | no functional change "No Functional Change" intended. Patch should not change tmt's behavior in any way. code | style Code style changes not affecting functionality status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish.
Projects
None yet
Milestone
1.38
Development

Successfully merging this pull request may close these issues.
3 participants
@happz @psss @therazix